[
https://issues.apache.org/jira/browse/BEAM-2939?focusedWorklogId=115667&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-115667
]
ASF GitHub Bot logged work on BEAM-2939:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jun/18 21:46
Start Date: 25/Jun/18 21:46
Worklog Time Spent: 10m
Work Description: jkff commented on a change in pull request #5566:
[BEAM-2939, BEAM-3743, BEAM-3833] Supports SDF in Reference Runner
URL: https://github.com/apache/beam/pull/5566#discussion_r197913219
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/splittabledofn/SDFFeederViaStateAndTimers.java
##########
@@ -0,0 +1,179 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.runners.fnexecution.splittabledofn;
+
+import static com.google.common.base.Preconditions.checkArgument;
+import static com.google.common.base.Preconditions.checkState;
+
+import com.google.common.collect.Iterables;
+import com.google.protobuf.ByteString;
+import java.io.IOException;
+import java.util.List;
+import org.apache.beam.model.fnexecution.v1.BeamFnApi.BundleSplit;
+import
org.apache.beam.model.fnexecution.v1.BeamFnApi.BundleSplit.DelayedApplication;
+import org.apache.beam.runners.core.StateInternals;
+import org.apache.beam.runners.core.StateNamespace;
+import org.apache.beam.runners.core.StateNamespaces;
+import org.apache.beam.runners.core.StateTag;
+import org.apache.beam.runners.core.StateTags;
+import org.apache.beam.runners.core.TimerInternals;
+import org.apache.beam.runners.core.TimerInternals.TimerData;
+import org.apache.beam.runners.core.construction.PTransformTranslation;
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.coders.KvCoder;
+import org.apache.beam.sdk.state.TimeDomain;
+import org.apache.beam.sdk.state.ValueState;
+import org.apache.beam.sdk.state.WatermarkHoldState;
+import org.apache.beam.sdk.transforms.windowing.BoundedWindow;
+import org.apache.beam.sdk.transforms.windowing.GlobalWindow;
+import org.apache.beam.sdk.transforms.windowing.TimestampCombiner;
+import org.apache.beam.sdk.util.CoderUtils;
+import org.apache.beam.sdk.util.WindowedValue;
+import org.apache.beam.sdk.util.WindowedValue.FullWindowedValueCoder;
+import org.apache.beam.sdk.values.KV;
+import org.joda.time.Duration;
+import org.joda.time.Instant;
+
+/**
+ * Helper class for feeding element/restricton pairs into a {@link
+ * PTransformTranslation#SPLITTABLE_PROCESS_ELEMENTS_URN} transform,
implementing checkpointing
+ * only, by using state and timers for storing the last element/restriction
pair, similarly to
+ * {@link
org.apache.beam.runners.core.SplittableParDoViaKeyedWorkItems.ProcessFn} but in
a portable
+ * fashion.
+ */
+public class SDFFeederViaStateAndTimers<InputT, RestrictionT> {
+ private final Coder<BoundedWindow> windowCoder;
+ private final Coder<WindowedValue<KV<InputT, RestrictionT>>>
elementRestrictionWireCoder;
+
+ private final StateInternals stateInternals;
+ private final TimerInternals timerInternals;
+
+ private StateNamespace stateNamespace;
+
+ private final StateTag<ValueState<WindowedValue<KV<InputT, RestrictionT>>>>
seedTag;
+ private ValueState<WindowedValue<KV<InputT, RestrictionT>>> seedState;
+
+ private final StateTag<ValueState<RestrictionT>> restrictionTag;
+ private ValueState<RestrictionT> restrictionState;
+
+ private StateTag<WatermarkHoldState> watermarkHoldTag =
+ StateTags.makeSystemTagInternal(
+ StateTags.<GlobalWindow>watermarkStateInternal("hold",
TimestampCombiner.LATEST));
+ private WatermarkHoldState holdState;
+
+ private Instant inputTimestamp;
+ private BundleSplit split;
+
+ /** Initializes the feeder. */
+ public SDFFeederViaStateAndTimers(
+ StateInternals stateInternals,
+ TimerInternals timerInternals,
+ Coder<InputT> elementWireCoder,
+ Coder<RestrictionT> restrictionWireCoder,
+ Coder<BoundedWindow> windowCoder) {
+ this.stateInternals = stateInternals;
+ this.timerInternals = timerInternals;
+ this.windowCoder = windowCoder;
+ this.elementRestrictionWireCoder =
+ FullWindowedValueCoder.of(KvCoder.of(elementWireCoder,
restrictionWireCoder), windowCoder);
+ this.seedTag = StateTags.value("seed", elementRestrictionWireCoder);
+ this.restrictionTag = StateTags.value("restriction", restrictionWireCoder);
+ }
+
+ /** Passes the initial element/restriction pair. */
+ public void seed(WindowedValue<KV<InputT, RestrictionT>> elementRestriction)
{
+ initState(
+ StateNamespaces.window(
+ windowCoder,
Iterables.getOnlyElement(elementRestriction.getWindows())));
+ seedState.write(elementRestriction);
+ inputTimestamp = elementRestriction.getTimestamp();
+ }
+
+ /**
+ * Resumes from a timer and returns the current element/restriction pair
(with an up-to-date value
+ * of the restriction).
+ */
+ public WindowedValue<KV<InputT, RestrictionT>> resume(TimerData timer) {
+ initState(timer.getNamespace());
+ WindowedValue<KV<InputT, RestrictionT>> seed = seedState.read();
+ inputTimestamp = seed.getTimestamp();
+ return seed.withValue(KV.of(seed.getValue().getKey(),
restrictionState.read()));
+ }
+
+ /**
+ * Commits the state and timers: clears both if no checkpoint happened, or
adjusts the restriction
+ * and sets a wake-up timer if a checkpoint happened.
+ */
+ public void commit() throws IOException {
+ if (split == null) {
+ // No split - the call terminated.
+ seedState.clear();
+ restrictionState.clear();
+ holdState.clear();
+ return;
+ }
+
+ // For now can only happen on the first instruction which is
SPLITTABLE_PROCESS_ELEMENTS.
+ List<DelayedApplication> residuals = split.getResidualRootsList();
+ checkArgument(residuals.size() == 1, "More than 1 residual is unsupported
for now");
+ DelayedApplication residual = residuals.get(0);
+
+ ByteString encodedResidual = residual.getApplication().getElement();
+ WindowedValue<KV<InputT, RestrictionT>> decodedResidual =
+ CoderUtils.decodeFromByteArray(elementRestrictionWireCoder,
encodedResidual.toByteArray());
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 115667)
Time Spent: 3h 10m (was: 3h)
> Fn API streaming SDF support
> ----------------------------
>
> Key: BEAM-2939
> URL: https://issues.apache.org/jira/browse/BEAM-2939
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Henning Rohde
> Assignee: Eugene Kirpichov
> Priority: Major
> Labels: portability
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The Fn API should support streaming SDF. Detailed design TBD.
> Once design is ready, expand subtasks similarly to BEAM-2822.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
