[
https://issues.apache.org/jira/browse/BEAM-2855?focusedWorklogId=115787&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-115787
]
ASF GitHub Bot logged work on BEAM-2855:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/18 06:22
Start Date: 26/Jun/18 06:22
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #5738:
[BEAM-2855] Add Python Nexmark suite
URL: https://github.com/apache/beam/pull/5738#discussion_r198022298
##########
File path:
sdks/python/apache_beam/testing/benchmarks/nexmark/nexmark_launcher.py
##########
@@ -143,8 +155,17 @@ def generate_events(pipeline, args, pipeline_options):
topic.publish(AUCTION_EVENT)
topic.publish(BID_EVENT)
+ # Large and comprehensive
Review comment:
I think you can remove this comment block. As we discussed offline,
ReadFromText does not work in streaming mode and WriteStringsToPubSub does not
work in batch mode. This pipeline would nor because of that.
It is fine to do the publishing in a loop in the test code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 115787)
Time Spent: 7h 10m (was: 7h)
> Implement a python version of the nexmark queries
> -------------------------------------------------
>
> Key: BEAM-2855
> URL: https://issues.apache.org/jira/browse/BEAM-2855
> Project: Beam
> Issue Type: Improvement
> Components: examples-nexmark, sdk-py-core, testing
> Reporter: Ismaël Mejía
> Assignee: María GH
> Priority: Minor
> Labels: newbie, nexmark, starter
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> Currently we have a Java only implementation of Nexmark, a python based
> implementation would be nice to have to validate the direct and dataflow
> runners, but also to validate the new support of multiple SDKs in multiple
> runners via the runner/fn API.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
