[
https://issues.apache.org/jira/browse/BEAM-4556?focusedWorklogId=116167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116167
]
ASF GitHub Bot logged work on BEAM-4556:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jun/18 21:46
Start Date: 26/Jun/18 21:46
Worklog Time Spent: 10m
Work Description: swegner commented on a change in pull request #5772:
[BEAM-4556] Update Findbugs annotations dependency to version with
SuppressFBWarnings
URL: https://github.com/apache/beam/pull/5772#discussion_r198308218
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -599,8 +599,12 @@ class BeamModulePlugin implements Plugin<Project> {
testApt auto_service
// These dependencies are needed to avoid error-prone warnings on
package-info.java files,
- // also to include the annotations to supress warnings.
- def findbugs_annotations =
"com.github.stephenc.findbugs:findbugs-annotations:1.3.9-1"
+ // also to include the annotations to suppress warnings.
+ //
+ // findbugs-annotations artifact is licensed under LGPL and cannot be
included in the
+ // Apache Beam distribution, but may be relied on during build.
+ // See: https://www.apache.org/legal/resolved.html#prohibited
+ def findbugs_annotations = "com.google.code.findbugs:annotations:3.0.1"
Review comment:
In this case we aren't using the annotations in our own Java source code;
[our byte-buddy
dependency](https://github.com/apache/beam/blob/d75365eeeff8d8b3fc6c97e582854ddcc9da49b6/sdks/java/core/build.gradle#L23)
uses them but [declares `findbugs-annotations` as a `provided`
dependency](https://github.com/raphw/byte-buddy/blob/471739c535aa2c17faf5fb5eafc4231e418e3796/pom.xml#L124),
so we need to also declare it to resolve their usages..
I think this is ok as long as we don't accidentally introduce a usage
down-the-road. Do you think we need an [API surface
test](https://github.com/apache/beam/blob/master/sdks/java/core/src/test/java/org/apache/beam/sdk/util/ApiSurfaceTest.java)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 116167)
Time Spent: 1h (was: 50m)
> Enforce ErrorProne analysis in sdks-java-core project
> -----------------------------------------------------
>
> Key: BEAM-4556
> URL: https://issues.apache.org/jira/browse/BEAM-4556
> Project: Beam
> Issue Type: Improvement
> Components: runner-direct
> Reporter: Scott Wegner
> Assignee: Scott Wegner
> Priority: Minor
> Labels: errorprone, starter
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently
> enabled|https://github.com/apache/beam/pull/5161] in the Gradle build
> process, but only as warnings. ErrorProne errors are generally useful and
> easy to fix. Some work was done to [make sdks-java-core
> ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add
> enforcement, but for unrelated reasons the {{failOnWarning}} setting needed
> to be reverted. This task is clean ErrorProne warnings and add enforcement in
> {{beam-sdks-java-core}}. Additional context discussed on the [dev
> list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution
> Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development
> environment.
> # Run the following command to compile and run ErrorProne analysis on the
> project: {{./gradlew :beam-sdks-java-core:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/core}} project.
> # In {{sdks/java/core/build.gradle}}, add {{failOnWarning: true}} to the call
> the {{applyJavaNature()}}
> ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach
> out|https://beam.apache.org/community/contact-us/] with questions or code
> review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
