[
https://issues.apache.org/jira/browse/BEAM-3761?focusedWorklogId=118585&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118585
]
ASF GitHub Bot logged work on BEAM-3761:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/18 05:57
Start Date: 03/Jul/18 05:57
Worklog Time Spent: 10m
Work Description: superbobry commented on issue #5843: [BEAM-3761] Define
cmp() in Python 3
URL: https://github.com/apache/beam/pull/5843#issuecomment-402021833
> There are no Jenkins build issues using my approach ;-)
No, but your approach introduces boilerplate. I think this is worth fixing
given that a) there seem to be no issue with importing from `past` on Cython,
and b) a `past` import is no less safe than try-except `NameError`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 118585)
Time Spent: 12h 20m (was: 12h 10m)
> Fix Python 3 cmp function
> -------------------------
>
> Key: BEAM-3761
> URL: https://issues.apache.org/jira/browse/BEAM-3761
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: holdenk
> Priority: Major
> Time Spent: 12h 20m
> Remaining Estimate: 0h
>
> Various functions don't exist in Python 3 that did in python 2. This Jira is
> to fix the use of cmp (which often will involve rewriting __cmp__ as well).
>
> Note: there are existing PRs for basestring and unicode (
> [https://github.com/apache/beam/pull/4697|https://github.com/apache/beam/pull/4697,]
> , [https://github.com/apache/beam/pull/4730] )
>
> Note once all of the missing names/functions are fixed we can enable F821 in
> falke8 python 3.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
