[
https://issues.apache.org/jira/browse/BEAM-4137?focusedWorklogId=118713&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118713
]
ASF GitHub Bot logged work on BEAM-4137:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/18 13:59
Start Date: 03/Jul/18 13:59
Worklog Time Spent: 10m
Work Description: echauchot edited a comment on issue #5876: [BEAM-4137]
Divide elasticsearch pipeline options
URL: https://github.com/apache/beam/pull/5876#issuecomment-402165634
@lgajowy sure, I'll be glad to review your PR. Splitting options is
something I wanted to do at the beginning of IT but Stephen Sisk who did the
first IT architecture told me that these options were not splittable due to the
architecture or integration tests. I don't remember the details but I seems to
have changed. I'm glad that we could finally split them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 118713)
Time Spent: 8h 10m (was: 8h)
> Split IOTestPipelineOptions to multiple, test-specific files
> ------------------------------------------------------------
>
> Key: BEAM-4137
> URL: https://issues.apache.org/jira/browse/BEAM-4137
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Łukasz Gajowy
> Assignee: Łukasz Gajowy
> Priority: Minor
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
> Currently we have one big IOTestPipelineOptions interface that is used in
> many IOITs. It contains test specific options that should rather be located
> next to testing classes, not in a generic file. Let's split this.
> Additionally, besides separation of concerns, this will allow adding
> test-specific @Default and @Required annotations and validate the options
> better.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
