[
https://issues.apache.org/jira/browse/BEAM-2732?focusedWorklogId=118879&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-118879
]
ASF GitHub Bot logged work on BEAM-2732:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jul/18 22:40
Start Date: 03/Jul/18 22:40
Worklog Time Spent: 10m
Work Description: pabloem commented on a change in pull request #5356:
[BEAM-2732][BEAM-4028] Logging relies on StateSampler for context
URL: https://github.com/apache/beam/pull/5356#discussion_r199965066
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -59,13 +59,12 @@
class RunnerIOOperation(operations.Operation):
"""Common baseclass for runner harness IO operations."""
- def __init__(self, operation_name, step_name, consumers, counter_factory,
+ def __init__(self, name_context, step_name, consumers, counter_factory,
state_sampler, windowed_coder, target, data_channel):
super(RunnerIOOperation, self).__init__(
- operation_name, None, counter_factory, state_sampler)
+ name_context, None, counter_factory, state_sampler)
self.windowed_coder = windowed_coder
self.windowed_coder_impl = windowed_coder.get_impl()
- self.step_name = step_name
Review comment:
This is part of my goal with BEAM-4028. The step name is meant to only be
retrievable through the name context.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 118879)
Time Spent: 17h (was: 16h 50m)
> State tracking in Python is inefficient and has duplicated code
> ---------------------------------------------------------------
>
> Key: BEAM-2732
> URL: https://issues.apache.org/jira/browse/BEAM-2732
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Major
> Time Spent: 17h
> Remaining Estimate: 0h
>
> e.g logging and metrics keep state separately. State tracking should be
> unified.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
