[
https://issues.apache.org/jira/browse/BEAM-4003?focusedWorklogId=119043&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-119043
]
ASF GitHub Bot logged work on BEAM-4003:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jul/18 11:05
Start Date: 04/Jul/18 11:05
Worklog Time Spent: 10m
Work Description: cclauss commented on a change in pull request #5373:
[BEAM-4003] Futurize runners subpackage
URL: https://github.com/apache/beam/pull/5373#discussion_r200090606
##########
File path: sdks/python/apache_beam/runners/dataflow/internal/apiclient.py
##########
@@ -28,12 +31,13 @@
import tempfile
import time
from datetime import datetime
-from StringIO import StringIO
+from io import BytesIO
import pkg_resources
from apitools.base.py import encoding
from apitools.base.py import exceptions
-import six
+
+from future import standard_library
Review comment:
I do not believe that you can just write __from future import
standard_library__. I believe that you must write __from
future.standard_library import install_aliases ; install_aliases()__ and
(despite what the linters will tell you) that call must happen before you
import effected modules. If I am wrong on this the please enlighten me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 119043)
Time Spent: 6h 20m (was: 6h 10m)
> Futurize and fix python 2 compatibility for runners subpackage
> --------------------------------------------------------------
>
> Key: BEAM-4003
> URL: https://issues.apache.org/jira/browse/BEAM-4003
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
