[
https://issues.apache.org/jira/browse/BEAM-4707?focusedWorklogId=119484&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-119484
]
ASF GitHub Bot logged work on BEAM-4707:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Jul/18 17:09
Start Date: 05/Jul/18 17:09
Worklog Time Spent: 10m
Work Description: lgajowy commented on a change in pull request #5889:
[BEAM-4707] insert timestamp to bigQuery as seconds as expected by BigQuery
URL: https://github.com/apache/beam/pull/5889#discussion_r200416970
##########
File path:
sdks/java/nexmark/src/test/java/org/apache/beam/sdk/nexmark/PerfsToBigQueryTest.java
##########
@@ -92,8 +92,11 @@ public void testSavePerfsToBigQuery() throws IOException,
InterruptedException {
HashMap<NexmarkConfiguration, NexmarkPerf> perfs = new HashMap<>(2);
perfs.put(nexmarkConfiguration1, nexmarkPerf1);
perfs.put(nexmarkConfiguration2, nexmarkPerf2);
- Instant start = Instant.now();
- Main.savePerfsToBigQuery(options, perfs, fakeBqServices, start);
+ //cast to int due to BEAM-4734. To avoid overflow on int capacity,
Review comment:
Nit: please add blank line between line 94 and 95.
Nit2: add space before "cast"
Maybe let's drop the ": Beam incubation date :)" part (imo, it may be
distractive and it's redundant)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 119484)
Time Spent: 5.5h (was: 5h 20m)
> Change fields and table names in nexmark perfkit tables
> -------------------------------------------------------
>
> Key: BEAM-4707
> URL: https://issues.apache.org/jira/browse/BEAM-4707
> Project: Beam
> Issue Type: Improvement
> Components: testing
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Fix For: 2.6.0
>
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Nexmark BQ tables for perfkit lack timestamp field. Also the table name
> contains a boolean than shows the mode of execution. It would be better to
> have batch or streaming label in place of the boolean.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
