[
https://issues.apache.org/jira/browse/BEAM-4742?focusedWorklogId=120881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-120881
]
ASF GitHub Bot logged work on BEAM-4742:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jul/18 16:48
Start Date: 09/Jul/18 16:48
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #5902:
[BEAM-4742] allow custom docker image in portable runner
URL: https://github.com/apache/beam/pull/5902#discussion_r201070593
##########
File path: sdks/python/apache_beam/examples/wordcount.py
##########
@@ -111,6 +113,10 @@ def format_result(word_count):
output = counts | 'format' >> beam.Map(format_result)
+ out_dir = os.path.dirname(known_args.output)
+ if not FileSystems.exists(out_dir):
Review comment:
I believe the expectation should be that any output path should be created
during pipeline execution and not by the driver program creating the pipeline.
Please revert this change to wordcount and fix the filesystem implementation
to create any necessary directories instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 120881)
Time Spent: 20m (was: 10m)
> Allow custom docker-image in portable wordcount example
> -------------------------------------------------------
>
> Key: BEAM-4742
> URL: https://issues.apache.org/jira/browse/BEAM-4742
> Project: Beam
> Issue Type: Improvement
> Components: examples-python
> Affects Versions: 2.5.0
> Reporter: Ryan Williams
> Assignee: Ryan Williams
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> I hit a couple snags [running the portable wordcount
> example|https://github.com/apache/beam/blob/997ee3afe74483ae44e2dcb32ca0e24876129cd9/sdks/python/build.gradle#L200-L214]:
> * [the default docker image is hard-coded to a bintray
> URL|https://github.com/apache/beam/blob/997ee3afe74483ae44e2dcb32ca0e24876129cd9/sdks/python/apache_beam/runners/portability/portable_runner.py#L60-L68],
> but I published my image to Docker Hub
> * the default output path is in a temporary directory that doesn't exist at
> the time of the {{open}} call, so I got {{IOError: [Errno 2] No such file or
> directory}}
> I'll send a PR with fixes to each of these shortly.
> I've also not found where to observe output from successfully running the
> example.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
