[
https://issues.apache.org/jira/browse/BEAM-3457?focusedWorklogId=121559&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121559
]
ASF GitHub Bot logged work on BEAM-3457:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/18 20:08
Start Date: 10/Jul/18 20:08
Worklog Time Spent: 10m
Work Description: lukecwik closed pull request #5917: [BEAM-3457] Upgrade
version of gogradle and add examples and containers to :goPrecommit
URL: https://github.com/apache/beam/pull/5917
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/build.gradle b/build.gradle
index 36aee89dccf..af2c411ed18 100644
--- a/build.gradle
+++ b/build.gradle
@@ -56,7 +56,7 @@ buildscript {
classpath "gradle.plugin.org.nosphere.apache:creadur-rat-gradle:0.3.1"
// Enable Apache license enforcement
classpath "com.commercehub.gradle.plugin:gradle-avro-plugin:0.11.0"
// Enable Avro code generation
classpath "com.diffplug.spotless:spotless-plugin-gradle:3.6.0"
// Enable a code formatting plugin
- classpath "gradle.plugin.com.github.blindpirate:gogradle:0.9"
// Enable Go code compilation
+ classpath "gradle.plugin.com.github.blindpirate:gogradle:0.10"
// Enable Go code compilation
classpath "gradle.plugin.com.palantir.gradle.docker:gradle-docker:0.13.0"
// Enable building Docker containers
classpath "cz.malohlava:visteg:1.0.3"
// Enable generating Gradle task dependencies as
".dot" files
classpath "com.github.jengelman.gradle.plugins:shadow:2.0.4"
// Enable shading Java dependencies
@@ -174,16 +174,15 @@ task goPreCommit() {
dependsOn ":rat"
dependsOn ":beam-sdks-go:test"
- // TODO: reenable when https://github.com/gogradle/gogradle/issues/225 is
fixed
- // dependsOn ":beam-sdks-go-examples:build"
- // dependsOn ":beam-sdks-go-test:build"
+ dependsOn ":beam-sdks-go-examples:build"
+ dependsOn ":beam-sdks-go-test:build"
// Ensure all container Go boot code builds as well.
- // dependsOn ":beam-sdks-java-container:build"
- // dependsOn ":beam-sdks-python-container:build"
- // dependsOn ":beam-sdks-go-container:build"
- // dependsOn ":beam-runners-gcp-gcemd:build"
- // dependsOn ":beam-runners-gcp-gcsproxy:build"
+ dependsOn ":beam-sdks-java-container:build"
+ dependsOn ":beam-sdks-python-container:build"
+ dependsOn ":beam-sdks-go-container:build"
+ dependsOn ":beam-runners-gcp-gcemd:build"
+ dependsOn ":beam-runners-gcp-gcsproxy:build"
}
task goPostCommit() {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 121559)
Time Spent: 5h 50m (was: 5h 40m)
> Migrate Go Jenkins PreCommit to Gradle
> --------------------------------------
>
> Key: BEAM-3457
> URL: https://issues.apache.org/jira/browse/BEAM-3457
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, testing
> Reporter: Luke Cwik
> Assignee: Henning Rohde
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> The code is here:
> https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_beam_PreCommit_Go_MavenInstall.groovy
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
