[ https://issues.apache.org/jira/browse/BEAM-4700?focusedWorklogId=121695&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121695 ]
ASF GitHub Bot logged work on BEAM-4700: ---------------------------------------- Author: ASF GitHub Bot Created on: 10/Jul/18 23:33 Start Date: 10/Jul/18 23:33 Worklog Time Spent: 10m Work Description: apilloud commented on issue #5919: BEAM-4700: [SQL] Default timezone is UTC URL: https://github.com/apache/beam/pull/5919#issuecomment-403998185 @lukecwik You like timezones. We made them not matter in Beam SQL by setting the default timezone to UTC instead of local time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 121695) Time Spent: 2h 20m (was: 2h 10m) > JDBC driver cannot support TIMESTAMP data type > ---------------------------------------------- > > Key: BEAM-4700 > URL: https://issues.apache.org/jira/browse/BEAM-4700 > Project: Beam > Issue Type: Bug > Components: dsl-sql > Reporter: Kenneth Knowles > Assignee: Andrew Pilloud > Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > > Avatica allows column representation to be customized, so a timestamp can be > stored as a variety of types. Joda ReadableInstant is none of these types: > https://github.com/apache/calcite-avatica/blob/acb675de97b9b0743c09368820a770e2ceda05f8/core/src/main/java/org/apache/calcite/avatica/util/AbstractCursor.java#L162 > By default, it seems to be configured to store {{TIMESTAMP}} columns as > {{long}} values. If you run the SQL shell and select a {{TIMESTAMP}} column, > you get: > {code} > ava.lang.ClassCastException: org.joda.time.Instant cannot be cast to > java.lang.Number > at > org.apache.beam.repackaged.beam_sdks_java_extensions_sql.org.apache.calcite.avatica.util.AbstractCursor$NumberAccessor.getNumber(AbstractCursor.java:726) > at > org.apache.beam.repackaged.beam_sdks_java_extensions_sql.org.apache.calcite.avatica.util.AbstractCursor$TimestampFromNumberAccessor.getString(AbstractCursor.java:1026) > at > org.apache.beam.repackaged.beam_sdks_java_extensions_sql.org.apache.calcite.avatica.AvaticaResultSet.getString(AvaticaResultSet.java:225) > at sqlline.Rows$Row.<init>(Rows.java:183) > {code} > So, essentially, Beam SQL Shell does not support timestamps. > We may be able to: > - override how the accessor for our existing storage is created > - configure what the column representation is (this doesn't really help, > since none of the choices are ours) > - convert timestamps to longs in BeamEnumerableConverter; not sure how many > conversions will be required here -- This message was sent by Atlassian JIRA (v7.6.3#76005)