[ https://issues.apache.org/jira/browse/BEAM-4691?focusedWorklogId=122191&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-122191 ]
ASF GitHub Bot logged work on BEAM-4691: ---------------------------------------- Author: ASF GitHub Bot Created on: 12/Jul/18 06:59 Start Date: 12/Jul/18 06:59 Worklog Time Spent: 10m Work Description: Ardagan1 commented on issue #5831: [BEAM-4691] (do-not-merge-yet!) Move perf tests to a separate directory and rename them (conventionally) URL: https://github.com/apache/beam/pull/5831#issuecomment-404410014 Hi Łukasz, Thank you for looking into this. Out of what I've seen so far: If we stay in current JobDSL world: I like your idea to generalize code for common job categories and define jobs via methods that accept map as parameters. If we can extract that map into separate file, that would be even better. Current amount of files is just too huge for amount of work that is done. In the state of pre- and post- commit world it already moves in the direction of splitting job definition into logic and data files. I believe finishing this work would be a good thing to do. If we move to jenkinsfile world: I believe it is worth at least looking into before rejecting. Main reasons I would vote for switching to jenkinsfile is that it is jenkins native way of doing things. Good [write up](https://marcesher.com/2016/08/04/jenkins-as-code-comparing-job-dsl-and-pipelines/) is mentioned on [job dsl wiki](https://github.com/jenkinsci/job-dsl-plugin/wiki/Talks-and-Blog-Posts). My opinion is that we should give jenkinsfile a try and make decision based on estimated amount of work required. One of the starting points can be [auto-convert plugin](https://wiki.jenkins.io/display/JENKINS/Convert+To+Pipeline+Plugin) that converts free-style jobs to jenkins pipeline. We can first try it on combination of forked repo and local jenkins docker instance to be safe. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 122191) Time Spent: 2h 50m (was: 2h 40m) > Rename (and reorganize?) jenkins jobs > ------------------------------------- > > Key: BEAM-4691 > URL: https://issues.apache.org/jira/browse/BEAM-4691 > Project: Beam > Issue Type: Task > Components: build-system > Reporter: Lukasz Gajowy > Assignee: Lukasz Gajowy > Priority: Minor > Time Spent: 2h 50m > Remaining Estimate: 0h > > Link to discussion: > [https://lists.apache.org/thread.html/ebe220ec1cebc73c8fb7190cf115fb9b23165fdbf950d58e05db544d@%3Cdev.beam.apache.org%3E] > Since jobs are Groovy files their names should be CamelCase. We could also > place them in subdirectories instead of prefixing job names. -- This message was sent by Atlassian JIRA (v7.6.3#76005)