[ https://issues.apache.org/jira/browse/BEAM-4622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexey Romanenko resolved BEAM-4622. ------------------------------------ Resolution: Fixed Fix Version/s: 2.6.0 > Many Beam SQL expressions never have their validation called > ------------------------------------------------------------ > > Key: BEAM-4622 > URL: https://issues.apache.org/jira/browse/BEAM-4622 > Project: Beam > Issue Type: Bug > Components: dsl-sql > Reporter: Kenneth Knowles > Assignee: Alexey Romanenko > Priority: Major > Labels: easyfix, newbie, starter > Fix For: 2.6.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > In {{BeamSqlFnExecutor}} there is a pattern where first the returned > expression is assigned to a variable {{ret}} and then after a giant switch > statement the validation is invoked. But there are many code paths that just > call {{return}} and skip validation. This should be refactored so it is > impossible to short-circuit on accident like this. -- This message was sent by Atlassian JIRA (v7.6.3#76005)