[
https://issues.apache.org/jira/browse/BEAM-4816?focusedWorklogId=124581&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124581
]
ASF GitHub Bot logged work on BEAM-4816:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Jul/18 20:08
Start Date: 18/Jul/18 20:08
Worklog Time Spent: 10m
Work Description: amaliujia closed pull request #5981: [BEAM-4816] Rename
JdbcJarTest to avoid run it in unit tests
URL: https://github.com/apache/beam/pull/5981
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/sdks/java/extensions/sql/jdbc/build.gradle
b/sdks/java/extensions/sql/jdbc/build.gradle
index f7dbb7cf66c..b41adcdbead 100644
--- a/sdks/java/extensions/sql/jdbc/build.gradle
+++ b/sdks/java/extensions/sql/jdbc/build.gradle
@@ -64,7 +64,7 @@ task shadowJarTest(type: Test, dependsOn:
":beam-sdks-java-extensions-sql-jdbc:s
systemProperty "driver.jar", configurations.shadowTestRuntimeClasspath[1]
- include '**/JdbcJarTest.class'
+ include '**/JdbcJarPreCommitCheck.class'
classpath = configurations.integrationTest
useJUnit { }
}
diff --git
a/sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/JdbcJarTest.java
b/sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/JdbcJarPreCommitCheck.java
similarity index 98%
rename from
sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/JdbcJarTest.java
rename to
sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/JdbcJarPreCommitCheck.java
index a8be594ba51..fc92a33f0c4 100644
---
a/sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/JdbcJarTest.java
+++
b/sdks/java/extensions/sql/jdbc/src/test/java/org/apache/beam/sdk/extensions/sql/jdbc/JdbcJarPreCommitCheck.java
@@ -33,7 +33,7 @@
import org.junit.rules.TemporaryFolder;
/** Test for JDBC via {@link java.net.URLClassLoader}. */
-public class JdbcJarTest {
+public class JdbcJarPreCommitCheck {
private static final String DRIVER_URL = "jdbc:beam:";
@Rule public TemporaryFolder folder = new TemporaryFolder();
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 124581)
Time Spent: 40m (was: 0.5h)
> Make JdbcJarTest not run in unit test mode.
> -------------------------------------------
>
> Key: BEAM-4816
> URL: https://issues.apache.org/jira/browse/BEAM-4816
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Right now JdbcJarTest runs in unit test mode when execute grade command
> :check or :test. Should avoid it and only allow JdbcJarTest run with
> :preCommit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
