[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=125536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-125536
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jul/18 15:38
Start Date: 20/Jul/18 15:38
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r204085546
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -234,6 +252,7 @@ def union(self, other):
min(self.start, other.start), max(self.end, other.end))
+@total_ordering
Review comment:
We have confirmed so far by bisection that the slowdown is caused by some
changes in `util.py` and/or `window.py`, and there are additional benchmark
runs in flight to narrow this down further. It is very likely that the slowdown
is caused by time it takes to compare objects of some of the classes defined in
`window.py` due to changes in implementation `cmp` or `hash` functions . I also
plan to confirm it with a microbenchmark similar to
https://github.com/apache/beam/compare/master...tvalentyn:utils_futurization_benchmark?expand=1#diff-de123c6d83f9809a6f0d95be5a7d1826
, that could help us to get performance metrics for different implementations
without running a slow benchmark suite.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 125536)
Time Spent: 8h 10m (was: 8h)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 8h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
