[
https://issues.apache.org/jira/browse/BEAM-3744?focusedWorklogId=126760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-126760
]
ASF GitHub Bot logged work on BEAM-3744:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jul/18 17:37
Start Date: 24/Jul/18 17:37
Worklog Time Spent: 10m
Work Description: charlesccychen commented on a change in pull request
#5952: [BEAM-3744] Python PubSub API Fixes and Tests
URL: https://github.com/apache/beam/pull/5952#discussion_r204846391
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -841,11 +841,12 @@ def run_Read(self, transform_node):
transform.source.id_label)
if transform.source.with_attributes:
# Setting this property signals Dataflow runner to return full
- # PubsubMessages instead of just the payload.
+ # PubsubMessages instead of just data.
step.add_property(PropertyNames.PUBSUB_SERIALIZED_ATTRIBUTES_FN, '')
if transform.source.timestamp_attribute is not None:
step.add_property(PropertyNames.PUBSUB_TIMESTAMP_ATTRIBUTE,
transform.source.timestamp_attribute)
+ logging.info('pubsub source')
Review comment:
debugging comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 126760)
Time Spent: 9h 50m (was: 9h 40m)
> Support full PubsubMessages
> ---------------------------
>
> Key: BEAM-3744
> URL: https://issues.apache.org/jira/browse/BEAM-3744
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Udi Meiri
> Assignee: Udi Meiri
> Priority: Critical
> Time Spent: 9h 50m
> Remaining Estimate: 0h
>
> Tracking changes to Pubsub support in Python SDK.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
