[ https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=126956&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-126956 ]
ASF GitHub Bot logged work on BEAM-4006: ---------------------------------------- Author: ASF GitHub Bot Created on: 24/Jul/18 23:40 Start Date: 24/Jul/18 23:40 Worklog Time Spent: 10m Work Description: tvalentyn commented on a change in pull request #5729: [BEAM-4006] Futurize transforms subpackage URL: https://github.com/apache/beam/pull/5729#discussion_r204944489 ########## File path: sdks/python/apache_beam/transforms/util.py ########## @@ -273,7 +279,7 @@ def div_keys(kv1_kv2): pairs = sorted(zip(sorted_data[::2], sorted_data[1::2]), key=div_keys) # Keep the top 1/3 most different pairs, average the top 2/3 most similar. - threshold = 2 * len(pairs) / 3 + threshold = 2 * len(pairs) // 3 Review comment: I have confirmed that this change brings performance back to the same ballpark. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 126956) Time Spent: 10h (was: 9h 50m) > Futurize and fix python 2 compatibility for transforms subpackage > ----------------------------------------------------------------- > > Key: BEAM-4006 > URL: https://issues.apache.org/jira/browse/BEAM-4006 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Robbe > Assignee: Matthias Feys > Priority: Major > Time Spent: 10h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)