[ 
https://issues.apache.org/jira/browse/BEAM-4866?focusedWorklogId=127429&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127429
 ]

ASF GitHub Bot logged work on BEAM-4866:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Jul/18 18:07
            Start Date: 25/Jul/18 18:07
    Worklog Time Spent: 10m 
      Work Description: lukecwik closed pull request #6062: [BEAM-4866] Fix 
missing licenses.
URL: https://github.com/apache/beam/pull/6062
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.test-infra/dockerized-jenkins/basic-security.groovy 
b/.test-infra/dockerized-jenkins/basic-security.groovy
index 669938256ce..8e0a20af948 100644
--- a/.test-infra/dockerized-jenkins/basic-security.groovy
+++ b/.test-infra/dockerized-jenkins/basic-security.groovy
@@ -1,4 +1,21 @@
 #!groovy
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
 
 import jenkins.model.*
 import hudson.security.*
diff --git a/.test-infra/dockerized-jenkins/config.xml 
b/.test-infra/dockerized-jenkins/config.xml
index cac2041db3a..06cce990763 100644
--- a/.test-infra/dockerized-jenkins/config.xml
+++ b/.test-infra/dockerized-jenkins/config.xml
@@ -1,4 +1,18 @@
 <?xml version='1.1' encoding='UTF-8'?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to You under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+       http://www.apache.org/licenses/LICENSE-2.0
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
 <hudson>
   <disabledAdministrativeMonitors/>
   <version>2.121.1</version>
@@ -38,4 +52,4 @@
   <label>beam</label>
   <nodeProperties/>
   <globalNodeProperties/>
-</hudson>
\ No newline at end of file
+</hudson>
diff --git 
a/.test-infra/dockerized-jenkins/javaposse.jobdsl.plugin.GlobalJobDslSecurityConfiguration.xml
 
b/.test-infra/dockerized-jenkins/javaposse.jobdsl.plugin.GlobalJobDslSecurityConfiguration.xml
index 6d808a28b49..f2683c0fd4d 100644
--- 
a/.test-infra/dockerized-jenkins/javaposse.jobdsl.plugin.GlobalJobDslSecurityConfiguration.xml
+++ 
b/.test-infra/dockerized-jenkins/javaposse.jobdsl.plugin.GlobalJobDslSecurityConfiguration.xml
@@ -1,5 +1,19 @@
 <?xml version='1.1' encoding='UTF-8'?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to You under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+       http://www.apache.org/licenses/LICENSE-2.0
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
 <javaposse.jobdsl.plugin.GlobalJobDslSecurityConfiguration 
plugin="job-dsl@1.69">
   <category class="jenkins.model.GlobalConfigurationCategory$Security"/>
   <useScriptSecurity>false</useScriptSecurity>
-</javaposse.jobdsl.plugin.GlobalJobDslSecurityConfiguration>
\ No newline at end of file
+</javaposse.jobdsl.plugin.GlobalJobDslSecurityConfiguration>
diff --git a/.test-infra/dockerized-jenkins/plugins.txt 
b/.test-infra/dockerized-jenkins/plugins.txt
index d61bb404bb9..4f0a09dd978 100644
--- a/.test-infra/dockerized-jenkins/plugins.txt
+++ b/.test-infra/dockerized-jenkins/plugins.txt
@@ -1,3 +1,18 @@
+#    Licensed to the Apache Software Foundation (ASF) under one or more
+#    contributor license agreements.  See the NOTICE file distributed with
+#    this work for additional information regarding copyright ownership.
+#    The ASF licenses this file to You under the Apache License, Version 2.0
+#    (the "License"); you may not use this file except in compliance with
+#    the License.  You may obtain a copy of the License at
+#
+#       http://www.apache.org/licenses/LICENSE-2.0
+#
+#    Unless required by applicable law or agreed to in writing, software
+#    distributed under the License is distributed on an "AS IS" BASIS,
+#    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+#    See the License for the specific language governing permissions and
+#    limitations under the License.
+
 CustomHistory
 gradle
 nodelabelparameter
diff --git a/.test-infra/dockerized-jenkins/seedjobconfig.xml 
b/.test-infra/dockerized-jenkins/seedjobconfig.xml
index fa7da63eb9b..2ede2430b45 100644
--- a/.test-infra/dockerized-jenkins/seedjobconfig.xml
+++ b/.test-infra/dockerized-jenkins/seedjobconfig.xml
@@ -1,4 +1,18 @@
 <?xml version='1.1' encoding='UTF-8'?>
+<!--
+    Licensed to the Apache Software Foundation (ASF) under one or more
+    contributor license agreements.  See the NOTICE file distributed with
+    this work for additional information regarding copyright ownership.
+    The ASF licenses this file to You under the Apache License, Version 2.0
+    (the "License"); you may not use this file except in compliance with
+    the License.  You may obtain a copy of the License at
+       http://www.apache.org/licenses/LICENSE-2.0
+    Unless required by applicable law or agreed to in writing, software
+    distributed under the License is distributed on an "AS IS" BASIS,
+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+    See the License for the specific language governing permissions and
+    limitations under the License.
+-->
 <project>
   <actions/>
   <description></description>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 127429)
    Time Spent: 20m  (was: 10m)

> RAT tests fail
> --------------
>
>                 Key: BEAM-4866
>                 URL: https://issues.apache.org/jira/browse/BEAM-4866
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>         Environment: Mac
>            Reporter: Elliotte Rusty Harold
>            Assignee: Luke Cwik
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> $ ./gradlew check
>  ...
>  4: Task failed with an exception.
>  -----------
>  * What went wrong:
>  Execution failed for task ':rat'.
>  > Found 5 files with unapproved/unknown licenses. See 
> [file:/Users/elharo/beam/build/reports/rat/rat-report.txt|file:///Users/elharo/beam/build/reports/rat/rat-report.txt]
>  ```
> I don't think these are likely to be real issues. Likely the tool just needs 
> to be configured a little differently:
>  
>  $ more /Users/elharo/beam/build/reports/rat/rat-report.txt
> *****************************************************
>  Summary
>  -------
>  Generated at: 2018-07-25T12:52:35-04:00
> Notes: 4
>  Binaries: 119
>  Archives: 4
>  Standards: 3935
> Apache Licensed: 3930
>  Generated Documents: 0
> JavaDocs are generated, thus a license header is optional.
>  Generated files do not require license headers.
> 5 Unknown Licenses
> *****************************************************
> Files with unapproved licenses:
> /Users/elharo/beam/.test-infra/dockerized-jenkins/basic-security.groovy
>  /Users/elharo/beam/.test-infra/dockerized-jenkins/config.xml
>  
> /Users/elharo/beam/.test-infra/dockerized-jenkins/javaposse.jobdsl.plugin.GlobalJobDslSecurityConfiguration.xml
>  /Users/elharo/beam/.test-infra/dockerized-jenkins/plugins.txt
>  /Users/elharo/beam/.test-infra/dockerized-jenkins/seedjobconfig.xml
> *****************************************************
>  ```



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to