[ https://issues.apache.org/jira/browse/BEAM-4751?focusedWorklogId=127596&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127596 ]
ASF GitHub Bot logged work on BEAM-4751: ---------------------------------------- Author: ASF GitHub Bot Created on: 26/Jul/18 00:13 Start Date: 26/Jul/18 00:13 Worklog Time Spent: 10m Work Description: tvalentyn commented on a change in pull request #5916: [BEAM-4751] fix missing pylint3 check for io subpackage URL: https://github.com/apache/beam/pull/5916#discussion_r205290053 ########## File path: sdks/python/apache_beam/io/vcfio.py ########## @@ -123,6 +124,9 @@ def __eq__(self, other): return (isinstance(other, Variant) and vars(self) == vars(other)) + def __hash__(self): + return hash((type(self), vars(self))) Review comment: `vars(self)` is unhashable since it's a `dict`. I think this would be dead code, so I suggest instead: ``` # To maintain compatibility with Python 3 __hash__ = None ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 127596) > Finish io futurize stage 2: fix the missing pylint3 check in tox.ini > -------------------------------------------------------------------- > > Key: BEAM-4751 > URL: https://issues.apache.org/jira/browse/BEAM-4751 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Matthias Feys > Assignee: Matthias Feys > Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > Finish io futurize stage 2: fix the missing pylint3 check in tox.ini -- This message was sent by Atlassian JIRA (v7.6.3#76005)