[ https://issues.apache.org/jira/browse/BEAM-4747?focusedWorklogId=127643&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-127643 ]
ASF GitHub Bot logged work on BEAM-4747: ---------------------------------------- Author: ASF GitHub Bot Created on: 26/Jul/18 05:06 Start Date: 26/Jul/18 05:06 Worklog Time Spent: 10m Work Description: ryan-williams commented on issue #5903: [BEAM-4747] mkdirs if they don't exist in localfilesystem URL: https://github.com/apache/beam/pull/5903#issuecomment-407977514 OK, I moved the dir-creation to apply on `create` but not `open`, added similar logic to `rename` and `copy`, and tried to add tests for all of them in a way that made sense. lmk what you think! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 127643) Time Spent: 40m (was: 0.5h) > Python LocalFileSystem directory-creation semantics > --------------------------------------------------- > > Key: BEAM-4747 > URL: https://issues.apache.org/jira/browse/BEAM-4747 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core > Affects Versions: 2.5.0 > Reporter: Ryan Williams > Assignee: Ryan Williams > Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > Coming out of discussion on > [BEAM-4742|https://issues.apache.org/jira/browse/BEAM-4742] / > [#5903|https://github.com/apache/beam/pull/5903] is a question of whether > {{LocalFileSystem.{open,create,copy,rename}}} should create > intermediate (destination) directories, or fail with {{IOError}}'s (as the > stdlib {{os}} module generally will). > If the semantics of {{LocalFileSystem}} should mimic those of distributed > filesystems (in the spirit of [recent discussion about {{DirectRunner}} being > more like a local simulation of a distributed runner than a production-grade > local > runner|https://www.mail-archive.com/dev@beam.apache.org/msg08410.html]), then > this makes sense, and it sounds like [~lcwik] and [~angoenka] are in favor of > this interpretation. > I'll repurpose [#5903|https://github.com/apache/beam/pull/5903] to this end > unless I hear otherwise. -- This message was sent by Atlassian JIRA (v7.6.3#76005)