[
https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=128317&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-128317
]
ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/18 22:25
Start Date: 27/Jul/18 22:25
Worklog Time Spent: 10m
Work Description: Fematich commented on a change in pull request #5729:
[BEAM-4006] Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r205913757
##########
File path: sdks/python/apache_beam/transforms/window.py
##########
@@ -348,6 +388,9 @@ def __eq__(self, other):
if type(self) == type(other) == FixedWindows:
return self.size == other.size and self.offset == other.offset
+ def __hash__(self):
+ return hash((type(self), self.size, self.offset))
+
def __ne__(self, other):
Review comment:
Adding
```
def __ne__(self, other):
return not self == other
```
for `IntervalWindow` causes `test_global_window` to fail on the last
assertion (comparing IntervalWindow (max-range) to GlobalWindow). To resolve
this failed assertion I need to add type in `__eq__`:
```
def __hash__(self):
return hash((self.start, self.end, type(self)))
def __eq__(self, other):
return (self.start == other.start
and self.end == other.end)
and type(self) == type(other))
def __ne__(self, other):
return not self == other
```
I think this makes sense and will be necessary for Python3 compatibility,
however I'm not sure if this will have performance impact here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 128317)
Time Spent: 12.5h (was: 12h 20m)
> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
> Key: BEAM-4006
> URL: https://issues.apache.org/jira/browse/BEAM-4006
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Matthias Feys
> Priority: Major
> Time Spent: 12.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
