[
https://issues.apache.org/jira/browse/BEAM-5023?focusedWorklogId=128915&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-128915
]
ASF GitHub Bot logged work on BEAM-5023:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jul/18 19:57
Start Date: 30/Jul/18 19:57
Worklog Time Spent: 10m
Work Description: angoenka commented on a change in pull request #6066:
[BEAM-5023] Send HarnessId in DataClient
URL: https://github.com/apache/beam/pull/6066#discussion_r206300830
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java
##########
@@ -150,7 +152,11 @@ public static void main(
RegisterHandler fnApiRegistry = new RegisterHandler();
BeamFnDataGrpcClient beamFnDataMultiplexer =
- new BeamFnDataGrpcClient(options, channelFactory::forDescriptor,
outboundObserverFactory);
+ new BeamFnDataGrpcClient(
+ options,
+
channelFactory.withInterceptors(ImmutableList.of(AddHarnessIdInterceptor.create(id)))
Review comment:
Makes sense.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 128915)
Time Spent: 10m
Remaining Estimate: 0h
> BeamFnDataGrpcClient should pass the worker_id when connecting to the
> RunnerHarness
> -----------------------------------------------------------------------------------
>
> Key: BEAM-5023
> URL: https://issues.apache.org/jira/browse/BEAM-5023
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
