[ https://issues.apache.org/jira/browse/BEAM-2930?focusedWorklogId=129086&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-129086 ]
ASF GitHub Bot logged work on BEAM-2930: ---------------------------------------- Author: ASF GitHub Bot Created on: 31/Jul/18 02:02 Start Date: 31/Jul/18 02:02 Worklog Time Spent: 10m Work Description: tweise closed pull request #6082: [BEAM-2930] Side inputs are not yet supported in streaming mode. URL: https://github.com/apache/beam/pull/6082 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingPortablePipelineTranslator.java b/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingPortablePipelineTranslator.java index d376e58ec4b..0a48edb8d6b 100644 --- a/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingPortablePipelineTranslator.java +++ b/runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingPortablePipelineTranslator.java @@ -433,17 +433,18 @@ private void translateImpulse( throw new RuntimeException(e); } - String inputPCollectionId = Iterables.getOnlyElement(transform.getInputsMap().values()); + String inputPCollectionId = stagePayload.getInput(); + // TODO: https://issues.apache.org/jira/browse/BEAM-2930 + if (stagePayload.getSideInputsCount() > 0) { + throw new UnsupportedOperationException( + "[BEAM-2930] streaming translator does not support side inputs: " + transform); + } Map<TupleTag<?>, OutputTag<WindowedValue<?>>> tagsToOutputTags = Maps.newLinkedHashMap(); Map<TupleTag<?>, Coder<WindowedValue<?>>> tagsToCoders = Maps.newLinkedHashMap(); // TODO: does it matter which output we designate as "main" - TupleTag<OutputT> mainOutputTag; - if (!outputs.isEmpty()) { - mainOutputTag = new TupleTag(outputs.keySet().iterator().next()); - } else { - mainOutputTag = null; - } + final TupleTag<OutputT> mainOutputTag = + outputs.isEmpty() ? null : new TupleTag(outputs.keySet().iterator().next()); // associate output tags with ids, output manager uses these Integer ids to serialize state BiMap<String, Integer> outputIndexMap = ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 129086) Time Spent: 2h (was: 1h 50m) > Flink support for portable side input > ------------------------------------- > > Key: BEAM-2930 > URL: https://issues.apache.org/jira/browse/BEAM-2930 > Project: Beam > Issue Type: Sub-task > Components: runner-flink > Reporter: Henning Rohde > Priority: Major > Labels: portability > Time Spent: 2h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)