[ https://issues.apache.org/jira/browse/BEAM-4761?focusedWorklogId=131073&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-131073 ]
ASF GitHub Bot logged work on BEAM-4761: ---------------------------------------- Author: ASF GitHub Bot Created on: 03/Aug/18 21:01 Start Date: 03/Aug/18 21:01 Worklog Time Spent: 10m Work Description: akedin commented on a change in pull request #6127: [BEAM-4761] Run Nexmark in thread pool URL: https://github.com/apache/beam/pull/6127#discussion_r207666623 ########## File path: sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Main.java ########## @@ -107,6 +168,14 @@ void runAll(OptionT options, NexmarkLauncher nexmarkLauncher) throws IOException saveSummary(options.getSummaryFilename(), configurations, actual, baseline, start, options); saveJavascript(options.getJavascriptFilename(), configurations, actual, baseline, start); } + + executor.shutdown(); + try { + if (!executor.awaitTermination(1L, TimeUnit.SECONDS)) { + throw new RuntimeException("Executor did not shutdown"); Review comment: nit: you're waiting for all runs to complete before reaching this point, and right after this you exit the program, so I'm not sure if it's worth waiting for executor termination ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 131073) Time Spent: 7h 20m (was: 7h 10m) > Add postCommit scripts and perfkit dashboards for nexmark on Dataflow runner > ---------------------------------------------------------------------------- > > Key: BEAM-4761 > URL: https://issues.apache.org/jira/browse/BEAM-4761 > Project: Beam > Issue Type: Test > Components: examples-nexmark > Reporter: Etienne Chauchot > Assignee: Andrew Pilloud > Priority: Major > Time Spent: 7h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)