[
https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=132715&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132715
]
ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Aug/18 22:10
Start Date: 08/Aug/18 22:10
Worklog Time Spent: 10m
Work Description: bsidhom commented on a change in pull request #6073:
[BEAM-4176] Validate Runner Tests generalization and enable for local reference
runner
URL: https://github.com/apache/beam/pull/6073#discussion_r208752428
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -1394,5 +1420,31 @@ artifactId=${project.name}
args argsNeeded
}
}
+
+
+ /**
***********************************************************************************************/
+
+ // Method to create the PortableValidatesRunnerTask.
+ // The method takes PortableValidatesRunnerConfiguration as parameter.
+ project.ext.createPortableValidatesRunnerTask = {
+ def config = it ? it as PortableValidatesRunnerConfiguration : new
PortableValidatesRunnerConfiguration()
+ def name = config.name
+ def beamTestPipelineOptions = [
+
"--runner=org.apache.beam.runners.reference.testing.TestPortableRunner",
+ "--jobServerDriver=${config.jobServerDriver}",
+ ]
+ if(config.jobServerConfig){
+
beamTestPipelineOptions.add("--jobServerConfig=${config.jobServerConfig}")
+ }
+ project.tasks.create(name: name, type: Test) {
+ group = "Verification"
+ description = "Validates the PortableRunner with JobServer
${config.jobServerDriver}"
+ systemProperty "beamTestPipelineOptions",
JsonOutput.toJson(beamTestPipelineOptions)
+ classpath = config.testClasspathConfiguration
+ testClassesDirs =
project.files(project.project(":beam-sdks-java-core").sourceSets.test.output.classesDirs,
project.project(":beam-runners-core-java").sourceSets.test.output.classesDirs)
Review comment:
Ah, I just realized that it's possible this will fail on submodules that
have not already added an evaluation dependency on beam-sdks-java-core
(necessary as we're accessing this source set here).
@lukecwik Do you know if there's a way to do this from within the plugin? Is
that even recommended if possible? Can we instead hard fail with a message if
the evaluation dependency has not been specified?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 132715)
Time Spent: 11h 20m (was: 11h 10m)
> Java: Portable batch runner passes all ValidatesRunner tests that
> non-portable runner passes
> --------------------------------------------------------------------------------------------
>
> Key: BEAM-4176
> URL: https://issues.apache.org/jira/browse/BEAM-4176
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Ben Sidhom
> Priority: Major
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
