[ https://issues.apache.org/jira/browse/BEAM-5113?focusedWorklogId=132720&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132720 ]
ASF GitHub Bot logged work on BEAM-5113: ---------------------------------------- Author: ASF GitHub Bot Created on: 08/Aug/18 22:15 Start Date: 08/Aug/18 22:15 Worklog Time Spent: 10m Work Description: akedin commented on a change in pull request #6186: [BEAM-5113][SQL] Add NOT LIKE based on LIKE expression URL: https://github.com/apache/beam/pull/6186#discussion_r208753444 ########## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/BeamSqlFnExecutor.java ########## @@ -278,7 +279,9 @@ private static BeamSqlExpression getBeamSqlExpression(RexNode rexNode) { case "LIKE": ret = new BeamSqlLikeExpression(subExps); break; - + case "NOT LIKE": + ret = new BeamSqlNotLikeExpression(subExps); Review comment: Can we just pass a flag into `BeamSqlLikeExpression`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 132720) Time Spent: 20m (was: 10m) > Test NOT LIKE > ------------- > > Key: BEAM-5113 > URL: https://issues.apache.org/jira/browse/BEAM-5113 > Project: Beam > Issue Type: Sub-task > Components: dsl-sql > Reporter: Rui Wang > Assignee: Rui Wang > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)