[
https://issues.apache.org/jira/browse/BEAM-5092?focusedWorklogId=132830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132830
]
ASF GitHub Bot logged work on BEAM-5092:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Aug/18 04:50
Start Date: 09/Aug/18 04:50
Worklog Time Spent: 10m
Work Description: timrobertson100 commented on a change in pull request
#6176: [[BEAM-5092] Row comparison should be faster when both are POJOs.
URL: https://github.com/apache/beam/pull/6176#discussion_r208805632
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java
##########
@@ -123,4 +124,27 @@ public int getFieldCount() {
public Object getGetterTarget() {
return getterTarget;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null) {
+ return false;
+ }
+ if (o instanceof RowWithGetters) {
+ RowWithGetters other = (RowWithGetters) o;
+ return Objects.equals(getSchema(), other.getSchema())
+ && Objects.equals(getterTarget, other.getterTarget);
Review comment:
Thanks - very helpful and agree on approach to document it.
Suggest somewhere doc the user might need to add a distinct() for cases
where they map partial rows in the source that can emit duplicate records.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 132830)
Time Spent: 4h 50m (was: 4h 40m)
> Nexmark 10x performance regression
> ----------------------------------
>
> Key: BEAM-5092
> URL: https://issues.apache.org/jira/browse/BEAM-5092
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Andrew Pilloud
> Assignee: Reuven Lax
> Priority: Critical
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> There looks to be a 10x performance hit on the DirectRunner and Flink nexmark
> jobs. It first showed up in this build:
> [https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Java_Nexmark_Direct/151/changes]
> [https://apache-beam-testing.appspot.com/explore?dashboard=5084698770407424]
> [https://apache-beam-testing.appspot.com/explore?dashboard=5699257587728384]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
