[
https://issues.apache.org/jira/browse/BEAM-5107?focusedWorklogId=134019&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-134019
]
ASF GitHub Bot logged work on BEAM-5107:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/18 17:47
Start Date: 12/Aug/18 17:47
Worklog Time Spent: 10m
Work Description: timrobertson100 commented on issue #6211: [BEAM-5107]
Support ES-6.x for ElasticsearchIO
URL: https://github.com/apache/beam/pull/6211#issuecomment-412359693
Thanks @dattran-vn01
I've commented on the Jira so design decisions taken will be easily
searchable/traceable.
I do agree this is a good approach, although I don't know what will happen
when you try and have an embedded ES6 on the classpath for a unit test. I've
offered an alternative approach on the Jira should that cause issue and we
should try and get agreement from others to go for a pragmatic approach.
As for the code you provided, I've only scanned quickly but first
impressions were very favourable. Thanks again.
(Please be aware that I am not a committer, so I can't merge it. I can
hopefully help speed up that process though)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 134019)
Time Spent: 1h 40m (was: 1.5h)
> Support ES 6.x for ElasticsearchIO
> ----------------------------------
>
> Key: BEAM-5107
> URL: https://issues.apache.org/jira/browse/BEAM-5107
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Dat Tran
> Assignee: Etienne Chauchot
> Priority: Minor
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Elasticsearch has released 6.3.2 but ElasticsearchIO only supports 2x-5.x.
> We should support ES 6.x for ElasticsearchIO.
> https://www.elastic.co/guide/en/elasticsearch/reference/current/index.html
> https://github.com/apache/beam/blob/master/sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
