[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=134784&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-134784
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/18 23:17
Start Date: 14/Aug/18 23:17
Worklog Time Spent: 10m
Work Description: ajamato commented on a change in pull request #6205:
[BEAM-4374] Implementing a subset of the new metrics framework in python.
URL: https://github.com/apache/beam/pull/6205#discussion_r210133169
##########
File path: model/fn-execution/src/main/proto/metric_definitions.yaml
##########
@@ -0,0 +1,57 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+# Metrics Definitions describing various BEAM metrics.
+# See: https://s.apache.org/beam-fn-api-metrics
+
+- annotations:
+ description: The total estimated execution time of the ptransform
+ unit: msecs
+ labels:
+ - PTRANSFORM
+ type: beam:metrics:SumInt64
+ urn: beam:metric:ptransform_execution_time:total_msecs:v1
+- annotations:
+ description: The total estimated execution time of the start bundle
function in
+ a pardo
+ unit: msecs
+ labels:
+ - PTRANSFORM
+ type: beam:metrics:SumInt64
+ urn: beam:metric:pardo_execution_time:start_bundle_msecs:v1
+- annotations:
+ description: The total estimated execution time of the process bundle
function
+ in a pardo
+ unit: msecs
+ labels:
+ - PTRANSFORM
+ type: beam:metrics:SumInt64
+ urn: beam:metric:pardo_execution_time:process_bundle_msecs:v1
+- annotations:
+ description: The total estimated execution time of the finish bundle
function
+ in a pardo
+ unit: msecs
+ labels:
+ - PTRANSFORM
+ type: beam:metrics:SumInt64
+ urn: beam:metric:pardo_execution_time:finish_bundle_msecs:v1
+- annotations:
+ description: The total elements counted for a metric.
+ labels:
+ - PTRANSFORM
+ type: beam:metrics:SumInt64
+ urn: beam:metric:element_count:v1
Review comment:
This file is for system defined ones, which we don't seem to have. As they
are only used in use counters. Unless I am missing something. Happy to add one
if we have an example in another SDK perhaps.
Right now this is just a catalog, its not actually loaded or used anywhere.
The doc covers how to add more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 134784)
Time Spent: 4h 20m (was: 4h 10m)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
