[
https://issues.apache.org/jira/browse/BEAM-3709?focusedWorklogId=135208&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-135208
]
ASF GitHub Bot logged work on BEAM-3709:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/18 00:15
Start Date: 16/Aug/18 00:15
Worklog Time Spent: 10m
Work Description: youngoli commented on a change in pull request #6128:
[BEAM-3709] Updating combine w/ side input translation in python.
URL: https://github.com/apache/beam/pull/6128#discussion_r210447001
##########
File path: sdks/python/apache_beam/transforms/core.py
##########
@@ -1358,6 +1358,11 @@ def expand(self, pcoll):
*args, **kwargs)
def to_runner_api_parameter(self, context):
+ if self.side_inputs:
Review comment:
I actually tried that already, but I believe some other case triggers that
statement even when there are no side inputs, because this would cause errors
with some tests I tried it on that were avoided with this version. I believe
something other than side inputs can be present in the args, or they may be
modified at some point, but I didn't have enough context to track down the
specifics. Also it didn't seem worth the effort just to make the code slightly
more easy to read.
I noticed @robertwb comes back tomorrow so he might be able to explain why
that happens. If not I would prefer to just leave a comment about it and leave
the code as-is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 135208)
Time Spent: 2.5h (was: 2h 20m)
> Implement the portable lifted Combiner transforms in Python SDK
> ---------------------------------------------------------------
>
> Key: BEAM-3709
> URL: https://issues.apache.org/jira/browse/BEAM-3709
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core, sdk-py-harness
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Labels: portability
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Lifted combines are split into separate parts with different URNs. These
> parts need to be implemented in the Python SDK harness so that the SDK can
> actually execute them when receiving Combine transforms with the
> corresponding URNs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
