[ 
https://issues.apache.org/jira/browse/BEAM-5141?focusedWorklogId=136267&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136267
 ]

ASF GitHub Bot logged work on BEAM-5141:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Aug/18 20:26
            Start Date: 20/Aug/18 20:26
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on issue #6216: [BEAM-5141] Improve 
error message when SET unregistered options
URL: https://github.com/apache/beam/pull/6216#issuecomment-414451527
 
 
   Your implementing custom input validation to get a custom SQL message in 
this PR (just using an exception to change the contract).
   
   The property descriptors should only be returned if all the classes are 
valid. So the majority of the validation is being done by 
PipelineOptionsFactory. The validation provided by SQL would be checking the 
list of already validated property descriptors for the property the user is 
trying to set.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 136267)
    Time Spent: 6h  (was: 5h 50m)

> Improve error message when SET unregistered options 
> ----------------------------------------------------
>
>                 Key: BEAM-5141
>                 URL: https://issues.apache.org/jira/browse/BEAM-5141
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Rui Wang
>            Assignee: Rui Wang
>            Priority: Major
>             Fix For: Not applicable
>
>          Time Spent: 6h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to