[
https://issues.apache.org/jira/browse/BEAM-5193?focusedWorklogId=136945&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136945
]
ASF GitHub Bot logged work on BEAM-5193:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/18 13:36
Start Date: 22/Aug/18 13:36
Worklog Time Spent: 10m
Work Description: iemejia closed pull request #6263: [BEAM-5193] Correct
typos in KuduIOTest testWrite
URL: https://github.com/apache/beam/pull/6263
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/sdks/java/io/kudu/src/test/java/org/apache/beam/sdk/io/kudu/KuduIOTest.java
b/sdks/java/io/kudu/src/test/java/org/apache/beam/sdk/io/kudu/KuduIOTest.java
index a39b87b4e22..55a2b72af15 100644
---
a/sdks/java/io/kudu/src/test/java/org/apache/beam/sdk/io/kudu/KuduIOTest.java
+++
b/sdks/java/io/kudu/src/test/java/org/apache/beam/sdk/io/kudu/KuduIOTest.java
@@ -125,9 +125,9 @@ public void testRead() throws KuduException {
}
/**
- * Test the write path using a {@link FakeWriter} and verifying the expected
log statements are
+ * Test the write path using a {@link FakeWriter} and verifies the expected
log statements are
* written. This test ensures that the {@link KuduIO} correctly respects
parallelism by
- * deserializes writers and that each writer is opening and closing Kudu
sessions.
+ * deserializing writers and that each writer is opening and closing Kudu
sessions.
*/
@Test
public void testWrite() throws Exception {
@@ -144,14 +144,14 @@ public void testWrite() throws Exception {
.withKuduService(mockWriteService));
writePipeline.run().waitUntilFinish();
- for (int i = 1; i <= targetParallelism + 1; i++) {
+ for (int i = 1; i <= targetParallelism; i++) {
expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_OPEN_SESSION,
i));
expectedWriteLogs.verifyDebug(
String.format(FakeWriter.LOG_WRITE, i)); // at least one per writer
expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_CLOSE_SESSION, i));
}
// verify all entries written
- for (int n = 0; n > numberRecords; n++) {
+ for (int n = 0; n < numberRecords; n++) {
expectedWriteLogs.verifyDebug(
String.format(FakeWriter.LOG_WRITE_VALUE, n)); // at least one per
writer
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 136945)
Time Spent: 1h (was: 50m)
> KuduIO testWrite not correctly verifying behaviour
> --------------------------------------------------
>
> Key: BEAM-5193
> URL: https://issues.apache.org/jira/browse/BEAM-5193
> Project: Beam
> Issue Type: Bug
> Components: io-ideas
> Affects Versions: 2.6.0
> Reporter: Tim Robertson
> Assignee: Tim Robertson
> Priority: Major
> Fix For: 2.7.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The {{testWrite}} in {{KuduIOTest}} has 2 typos which were committed in error.
> The following code block
> {code:java}
> for (int i = 1; i <= targetParallelism + 1; i++) {
>
> expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_OPEN_SESSION, i));
> expectedWriteLogs.verifyDebug(
> String.format(FakeWriter.LOG_WRITE, i)); // at least one per writer
>
> expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_CLOSE_SESSION, i));
> }
> // verify all entries written
> for (int n = 0; n > numberRecords; n++) {
> expectedWriteLogs.verifyDebug(
> String.format(FakeWriter.LOG_WRITE_VALUE, n)); // at least one per
> writer
> }
> {code}
>
> Should have read:
> {code:java}
> for (int i = 1; i <= targetParallelism ; i++) {
>
> expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_OPEN_SESSION, i));
> expectedWriteLogs.verifyDebug(
> String.format(FakeWriter.LOG_WRITE, i)); // at least one per writer
>
> expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_CLOSE_SESSION, i));
> }
> // verify all entries written
> for (int n = 0; n < numberRecords; n++) {
> expectedWriteLogs.verifyDebug(
> String.format(FakeWriter.LOG_WRITE_VALUE, n)); // at least one per
> writer
> }
> {code}
> This has gone unnoticed because 1) the {{targetParallelism}} is a function of
> cores available, and the test uses 3 only (which is the min in
> {{DirectRunner}}) and 2) the incorrect {{>}} in the test simply meant the
> loop was not run.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
