[
https://issues.apache.org/jira/browse/BEAM-5239?focusedWorklogId=139639&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-139639
]
ASF GitHub Bot logged work on BEAM-5239:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/18 10:41
Start Date: 30/Aug/18 10:41
Worklog Time Spent: 10m
Work Description: JozoVilcek commented on a change in pull request #6278:
[BEAM-5239] Enable to configure latencyTrackingInterval
URL: https://github.com/apache/beam/pull/6278#discussion_r213983463
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkExecutionEnvironments.java
##########
@@ -171,4 +176,12 @@ public static StreamExecutionEnvironment
createStreamExecutionEnvironment(
return flinkStreamEnv;
}
+
+ private static void applyLatencyTrackingInterval(
+ ExecutionConfig config, FlinkPipelineOptions options) {
+ long latencyTrackingInterval = options.getLatencyTrackingInterval();
+ if (latencyTrackingInterval >= 0) {
Review comment:
Idea was to stick to default flink configuration, unless user intend to
overwrite it. With this PR I have a choice to disable it by passing to runner
`--latencyTrackingInterval=0`.
Did not wanted to disable it for all by default. Should I?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 139639)
Time Spent: 1h 40m (was: 1.5h)
> Allow configure latencyTrackingInterval
> ---------------------------------------
>
> Key: BEAM-5239
> URL: https://issues.apache.org/jira/browse/BEAM-5239
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Affects Versions: 2.6.0
> Reporter: Jozef Vilcek
> Assignee: Aljoscha Krettek
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Because of FLINK-10226, we need to be able to set
> latencyTrackingConfiguration for flink via FlinkPipelineOptions
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
