[
https://issues.apache.org/jira/browse/BEAM-5149?focusedWorklogId=141517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-141517
]
ASF GitHub Bot logged work on BEAM-5149:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/18 20:15
Start Date: 05/Sep/18 20:15
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6222:
[BEAM-5149] Add support for the Java SDK harness to merge windows.
URL: https://github.com/apache/beam/pull/6222#discussion_r215410924
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/WindowMappingFnRunner.java
##########
@@ -32,9 +32,17 @@
import org.apache.beam.sdk.values.KV;
/**
- * Maps windows using a window mapping fn. The input is {@link KV} with the
key being a nonce and
- * the value being a window, the output must be a {@link KV} with the key
being the same nonce as
- * the input and the value being the mapped window.
+ * Represents mapping of main input window onto side input window.
+ *
+ * <p>Side input window mapping function:
+ *
+ * <ul>
+ * <li>Input: {@code KV<nonce, SideInputWindow>}
+ * <li>Output: {@code KV<nonce, MainInputWindow>}
+ * </ul>
+ *
+ * <p>For each main input window, the side input window is returned. The nonce
is used by a runner
Review comment:
Ditto on copy paste typo
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 141517)
Time Spent: 1h 10m (was: 1h)
> Add support to the Java SDK harness to merge windows
> ----------------------------------------------------
>
> Key: BEAM-5149
> URL: https://issues.apache.org/jira/browse/BEAM-5149
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-harness
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Window merging function:
>
> {code:java}
> Input: KV<nonce, iterable<OriginalWindow>>
> Output: KV<nonce, KV<iterable<UnmergedOriginalWindow>,
> iterable<KV<MergedWindow, iterable<ConsumedOriginalWindow>>>>
> {code}
> For each set of original windows, a list of all unmerged windows is output
> alongside a map of merged window to set of consumed windows. All original
> windows must be contained in either the unmerged original window set or one
> of the consumed original window sets. Each original window can only be part
> of one output set. The nonce is used by a runner to associate each input with
> its output. The nonce is represented as an opaque set of bytes.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
