[
https://issues.apache.org/jira/browse/BEAM-5376?focusedWorklogId=143996&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-143996
]
ASF GitHub Bot logged work on BEAM-5376:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/18 16:03
Start Date: 13/Sep/18 16:03
Worklog Time Spent: 10m
Work Description: apilloud commented on a change in pull request #6383:
[BEAM-5376] Support nullability on all Row types
URL: https://github.com/apache/beam/pull/6383#discussion_r217442586
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/schemas/JavaBeanSchemaTest.java
##########
@@ -155,10 +155,10 @@ public void testRecursiveGetters() throws
NoSuchSchemaException {
Row nestedRow = row.getRow("nested");
assertEquals("string", nestedRow.getString("str"));
- assertEquals((byte) 1, nestedRow.getByte("aByte"));
- assertEquals((short) 2, nestedRow.getInt16("aShort"));
- assertEquals((int) 3, nestedRow.getInt32("anInt"));
- assertEquals((long) 4, nestedRow.getInt64("aLong"));
+ assertEquals((byte) 1, (Object) nestedRow.getByte("aByte"));
Review comment:
Undoing this diff results in the following failure:
```
JavaBeanSchemaTest.java:158: error: reference to assertEquals is ambiguous
assertEquals((byte) 1, nestedRow.getByte("aByte"));
^
both method assertEquals(long,long) in Assert and method
assertEquals(Object,Object) in Assert match
```
@amaliuja Your suggestion results in the following failure:
```
JavaBeanSchemaTest.java:158: error: incompatible types: int cannot be
converted to Byte
assertEquals((Byte) 1, (Byte) nestedRow.getByte("aByte"));
```
@akedin Your suggestion results in the following failure:
```
assertEquals(Byte.valueOf(1), nestedRow.getByte("aByte"));
^
method Byte.valueOf(byte) is not applicable
(argument mismatch; possible lossy conversion from int to byte)
method Byte.valueOf(String) is not applicable
(argument mismatch; int cannot be converted to String)
```
Using `assertTrue` is incorrect because it does not print the values on
failure. I'm happy to change the syntax, but none of these options work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 143996)
Time Spent: 1h (was: 50m)
> Row interface doesn't support nullability on all fields.
> --------------------------------------------------------
>
> Key: BEAM-5376
> URL: https://issues.apache.org/jira/browse/BEAM-5376
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Andrew Pilloud
> Assignee: Andrew Pilloud
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> For example:
> {code:java}
> public boolean getBoolean(int idx);{code}
> Should be:
> {code:java}
> public Boolean getBoolean(int idx);{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
