[
https://issues.apache.org/jira/browse/BEAM-4704?focusedWorklogId=144035&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144035
]
ASF GitHub Bot logged work on BEAM-4704:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/18 17:55
Start Date: 13/Sep/18 17:55
Worklog Time Spent: 10m
Work Description: apilloud opened a new pull request #6389: [BEAM-4704]
Disable enumerable rules, use direct runner
URL: https://github.com/apache/beam/pull/6389
This keeps everything going through a single path. We can add back
enumerable value rules later if we want.
------------------------
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [X] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [X] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
It will help us expedite review of your Pull Request if you tag someone
(e.g. `@username`) to look at it.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| --- | --- | --- | ---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 144035)
Time Spent: 10m
Remaining Estimate: 0h
> String operations yield incorrect results when executed through SQL shell
> -------------------------------------------------------------------------
>
> Key: BEAM-4704
> URL: https://issues.apache.org/jira/browse/BEAM-4704
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{TRIM}} is defined to trim _all_ the characters in the first string from the
> string-to-be-trimmed. Calcite has an incorrect implementation of this. We use
> our own fixed implementation. But when executed through the SQL shell, the
> results do not match what we get from the PTransform path. Here two test
> cases that pass on {{master}} but are incorrect in the shell:
> {code:sql}
> BeamSQL> select TRIM(LEADING 'eh' FROM 'hehe__hehe');
> +------------+
> | EXPR$0 |
> +------------+
> | hehe__hehe |
> +------------+
> {code}
> {code:sql}
> BeamSQL> select TRIM(TRAILING 'eh' FROM 'hehe__hehe');
> +------------+
> | EXPR$0 |
> +------------+
> | hehe__heh |
> +------------+
> {code}
> {code:sql}
> BeamSQL> select TRIM(BOTH 'eh' FROM 'hehe__hehe');
> +------------+
> | EXPR$0 |
> +------------+
> | hehe__heh |
> +------------+
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
