[
https://issues.apache.org/jira/browse/BEAM-5288?focusedWorklogId=144444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144444
]
ASF GitHub Bot logged work on BEAM-5288:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Sep/18 20:18
Start Date: 14/Sep/18 20:18
Worklog Time Spent: 10m
Work Description: angoenka commented on issue #6373: [BEAM-5288] [NOT
READY FOR MERGE]Enhance Environment proto to support different types of
environments
URL: https://github.com/apache/beam/pull/6373#issuecomment-421473275
@tweise The dataflow runner already use the field, of course we can make the
breaking change and fix it in dataflow by tagging but to do a smooth
transition, I hope to keep the URL field and remove in a subsequent PR.
@mxm Absolutely. I will mark URL as deprecated and get rid of it ASAP.
Yes, I think I missed the GO code. I wonder why it did not break. Probably
we need to regenerate the proto code as generated code is also checked in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 144444)
Time Spent: 2h 40m (was: 2.5h)
> Modify Environment to support non-dockerized SDK harness deployments
> ---------------------------------------------------------------------
>
> Key: BEAM-5288
> URL: https://issues.apache.org/jira/browse/BEAM-5288
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Maximilian Michels
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> As of mailing discussions and BEAM-5187, it has become clear that we need to
> extend the Environment information. In addition to the Docker environment,
> the extended environment holds deployment options for 1) a process-based
> environment, 2) an externally managed environment.
> The proto definition, as of now, looks as follows:
> {noformat}
> message Environment {
> // (Required) The URN of the payload
> string urn = 1;
> // (Optional) The data specifying any parameters to the URN. If
> // the URN does not require any arguments, this may be omitted.
> bytes payload = 2;
> }
> message StandardEnvironments {
> enum Environments {
> DOCKER = 0 [(beam_urn) = "beam:env:docker:v1"];
> PROCESS = 1 [(beam_urn) = "beam:env:process:v1"];
> EXTERNAL = 2 [(beam_urn) = "beam:env:external:v1"];
> }
> }
> // The payload of a Docker image
> message DockerPayload {
> string container_image = 1; // implicitly linux_amd64.
> }
> message ProcessPayload {
> string os = 1; // "linux", "darwin", ..
> string arch = 2; // "amd64", ..
> string command = 3; // process to execute
> map<string, string> env = 4; // environment variables
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
