[ https://issues.apache.org/jira/browse/BEAM-5317?focusedWorklogId=144522&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144522 ]
ASF GitHub Bot logged work on BEAM-5317: ---------------------------------------- Author: ASF GitHub Bot Created on: 15/Sep/18 01:17 Start Date: 15/Sep/18 01:17 Worklog Time Spent: 10m Work Description: tvalentyn commented on a change in pull request #6397: [BEAM-5317] Finish Python3 porting for options module URL: https://github.com/apache/beam/pull/6397#discussion_r217871523 ########## File path: sdks/python/apache_beam/options/pipeline_options_validator_test.py ########## @@ -311,7 +311,7 @@ def get_validator(matcher): '--staging_location=gs://foo/bar', '--temp_location=gs://foo/bar',] if matcher: - options.append('--on_success_matcher=' + matcher) + options.append('%s=%s' % ('--on_success_matcher=', matcher.decode())) Review comment: After `--on_success_matcher`. Also please squash the previous commits. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 144522) Time Spent: 3.5h (was: 3h 20m) > Finish Python 3 porting for options module > ------------------------------------------ > > Key: BEAM-5317 > URL: https://issues.apache.org/jira/browse/BEAM-5317 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Robbe > Assignee: Manu Zhang > Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)