[ 
https://issues.apache.org/jira/browse/BEAM-5264?focusedWorklogId=144728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-144728
 ]

ASF GitHub Bot logged work on BEAM-5264:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Sep/18 06:07
            Start Date: 17/Sep/18 06:07
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on a change in pull request 
#6304: [BEAM-5264] Reference DirectRunner implementation of Python User State 
and Timers API
URL: https://github.com/apache/beam/pull/6304#discussion_r217950693
 
 

 ##########
 File path: sdks/python/apache_beam/runners/common.py
 ##########
 @@ -159,6 +159,28 @@ def __init__(self, obj_to_invoke, method_name):
     self.args = args
     self.defaults = defaults
 
+    self.has_userstate_arguments = False
+    self.state_args_to_replace = {}
+    self.timer_args_to_replace = {}
+    for kw, v in zip(args[-len(defaults):], defaults):
+      if v.__class__ == core.DoFn.StateParam:
 
 Review comment:
   Okay, done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 144728)
    Time Spent: 5h 40m  (was: 5.5h)

> Reference DirectRunner implementation of Python user state and timers API
> -------------------------------------------------------------------------
>
>                 Key: BEAM-5264
>                 URL: https://issues.apache.org/jira/browse/BEAM-5264
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>    Affects Versions: 2.6.0
>            Reporter: Charles Chen
>            Assignee: Charles Chen
>            Priority: Major
>          Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> This issue tracks the reference DirectRunner implementation of the Beam 
> Python User State and Timer API, described here: 
> [https://s.apache.org/beam-python-user-state-and-timers].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to