[ 
https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=146347&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146347
 ]

ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/18 12:03
            Start Date: 21/Sep/18 12:03
    Worklog Time Spent: 10m 
      Work Description: tweise commented on issue #6447: [BEAM-5442] Add 
FlinkOptions to Python SDK
URL: https://github.com/apache/beam/pull/6447#issuecomment-423508484
 
 
   @mxm I did see your comment on the JIRA and think that's fine. I just don't 
see the change here that passes through unknown options. My concern is that we 
have to open a new pull request for any other option that we may need while we 
can handle that generically (with a warning perhaps).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 146347)
    Time Spent: 2h 10m  (was: 2h)

> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
>                 Key: BEAM-5442
>                 URL: https://issues.apache.org/jira/browse/BEAM-5442
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core, sdk-py-core
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Major
>              Labels: portability, portability-flink
>             Fix For: 2.8.0
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing 
> Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the 
> PortableRunner. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to