[
https://issues.apache.org/jira/browse/BEAM-4449?focusedWorklogId=146622&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-146622
]
ASF GitHub Bot logged work on BEAM-4449:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/18 22:44
Start Date: 21/Sep/18 22:44
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #6382:
[BEAM-4449] Finish splitting Aggregate and Project
URL: https://github.com/apache/beam/pull/6382#discussion_r219644569
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/BeamSqlFnExecutor.java
##########
@@ -504,21 +501,6 @@ private static BeamSqlExpression
getBeamSqlExpression(RexNode rexNode) {
ret = new BeamSqlIsNotNullExpression(subExps.get(0));
break;
- case "HOP":
- case "TUMBLE":
- case "SESSION":
- ret = new BeamSqlWindowExpression(subExps,
node.type.getSqlTypeName());
Review comment:
It seems that our implementation of window start/end has never worked
because Calcite convert window start to a column reference and window end to a
PLUS operation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 146622)
Time Spent: 8h 20m (was: 8h 10m)
> Use Calc instead of Project and Filter separately
> -------------------------------------------------
>
> Key: BEAM-4449
> URL: https://issues.apache.org/jira/browse/BEAM-4449
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Fix For: 2.5.0
>
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> Calcite has a combined Calc operator that is amenable to more optimization,
> and also means less code to manage as we adjust how the operators/expressions
> are implemented.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
