[
https://issues.apache.org/jira/browse/BEAM-5427?focusedWorklogId=147202&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-147202
]
ASF GitHub Bot logged work on BEAM-5427:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/18 16:55
Start Date: 24/Sep/18 16:55
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #6439:
[BEAM-5427] Fix and update sample code for CombineFn.
URL: https://github.com/apache/beam/pull/6439#discussion_r219909799
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Combine.java
##########
@@ -289,6 +305,20 @@ private Combine() {
* arbitrary tree structure. Commutativity is required because any order of
the input values is
* ignored when breaking up input values into groups.
*
+ * <h3>Note on Data Encoding</h3>
+ *
+ * <p>Some form of data encoding is required when using custom types in a
CombineFn which do not
Review comment:
It would be better to say something along the lines:
We are relying on the fact that there is a generic `CoderProvider` that is
able to provide a coder for any `Serializable`. In general there are two ways
in which a coder for the accumulator type is provided:
* It can be provided by the default CoderRegistry. See the CoderRegistry for
the numerous ways in which to bind a type to a coder.
* The `getAccumulatorCoder` method is overridden and provides the coder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 147202)
Time Spent: 2h 20m (was: 2h 10m)
> Fix sample code (AverageFn) in Combine.java
> -------------------------------------------
>
> Key: BEAM-5427
> URL: https://issues.apache.org/jira/browse/BEAM-5427
> Project: Beam
> Issue Type: Improvement
> Components: examples-java
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Sample code missing coder.
> In its current state, job run fails with Coder missing error.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
