[
https://issues.apache.org/jira/browse/BEAM-5417?focusedWorklogId=147547&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-147547
]
ASF GitHub Bot logged work on BEAM-5417:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/18 13:01
Start Date: 25/Sep/18 13:01
Worklog Time Spent: 10m
Work Description: joar commented on issue #6423: [BEAM-5417] Parity
between GCS and local match
URL: https://github.com/apache/beam/pull/6423#issuecomment-424333429
> I think that doing our own conversion of glob pattern to regex is the best
solution.
@udim I agree, pushed a solution that uses a customized version of [Python
2.7's
fnmatch.translate](https://github.com/python/cpython/blob/170ea8ccd4235d28538ab713041502d07ad1cacd/Lib/fnmatch.py#L85-L120).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 147547)
Time Spent: 2.5h (was: 2h 20m)
> FileSystems.match behaviour diff between GCS and local file system
> ------------------------------------------------------------------
>
> Key: BEAM-5417
> URL: https://issues.apache.org/jira/browse/BEAM-5417
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Affects Versions: 2.5.0, 2.6.0
> Reporter: Joar Wandborg
> Assignee: Chamikara Jayalath
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Given the directory structure:
>
> {noformat}
> .
> ├── filesystem-match-test
> │ ├── a
> │ │ └── file.txt
> │ └── b
> │ └── file.txt
> └── filesystem-match-test.py
> {noformat}
>
> Where {{filesystem-match-test.py}} contains:
> {code:python}
> from __future__ import print_function
> import os
> import posixpath
> from apache_beam.io.filesystem import MatchResult
> from apache_beam.io.filesystems import FileSystems
> BASES = [
> os.path.join(os.path.dirname(__file__), "./"),
> "gs://my-bucket/test/",
> ]
> pattern = "filesystem-match-test/*/file.txt"
> for base_path in BASES:
> full_pattern = posixpath.join(base_path, pattern)
> print("full_pattern: {}".format(full_pattern))
> match_result = FileSystems.match([full_pattern])[0] # type: MatchResult
> print("metadata list: {}".format(match_result.metadata_list))
> {code}
> Running {{python filesystem-match-test.py}} does not match any files locally,
> but does match files on GCS:
> {noformat}
> full_pattern: ./filesystem-match-test/*/file.txt
> metadata list: []
> full_pattern: gs://my-bucket/test/filesystem-match-test/*/file.txt
> metadata list:
> [FileMetadata(gs://my-bucket/test/filesystem-match-test/a/file.txt, 6),
> FileMetadata(gs://my-bucket/test/filesystem-match-test/b/file.txt, 6)]
> {noformat}
> The expected result is that a/file.txt and b/file.txt should be matched for
> both patterns.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
