[
https://issues.apache.org/jira/browse/BEAM-5288?focusedWorklogId=147641&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-147641
]
ASF GitHub Bot logged work on BEAM-5288:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/18 16:23
Start Date: 25/Sep/18 16:23
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6441:
[BEAM-5288] Support environment pipeline option in Java and Python.
URL: https://github.com/apache/beam/pull/6441#discussion_r220252508
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -655,11 +655,18 @@ def _add_argparse_args(cls, parser):
help=
('Job service endpoint to use. Should be in the form '
'of address and port, e.g. localhost:3000'))
- parser.add_argument('--harness_docker_image',
- default=None,
- help=
- ('Docker image to use for executing Python code '
- 'in the pipeline when running using the Fn API.'))
+ parser.add_argument(
+ '--python_environment_type', default=None,
+ help=('Set the default environment type for running '
+ 'user code. Possible options are DOCKER and PROCESS.'))
+ parser.add_argument(
+ '--python_environment_config', default=None,
+ help=('Set environment configuration for running the user code. \n For
'
+ 'DOCKER: Url for the docker image. \n For PROCESS: json of the '
Review comment:
Extra spaces before `\n`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 147641)
Time Spent: 11h (was: 10h 50m)
> Modify Environment to support non-dockerized SDK harness deployments
> ---------------------------------------------------------------------
>
> Key: BEAM-5288
> URL: https://issues.apache.org/jira/browse/BEAM-5288
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Maximilian Michels
> Assignee: Ankur Goenka
> Priority: Major
> Time Spent: 11h
> Remaining Estimate: 0h
>
> As of mailing discussions and BEAM-5187, it has become clear that we need to
> extend the Environment information. In addition to the Docker environment,
> the extended environment holds deployment options for 1) a process-based
> environment, 2) an externally managed environment.
> The proto definition, as of now, looks as follows:
> {noformat}
> message Environment {
> // (Required) The URN of the payload
> string urn = 1;
> // (Optional) The data specifying any parameters to the URN. If
> // the URN does not require any arguments, this may be omitted.
> bytes payload = 2;
> }
> message StandardEnvironments {
> enum Environments {
> DOCKER = 0 [(beam_urn) = "beam:env:docker:v1"];
> PROCESS = 1 [(beam_urn) = "beam:env:process:v1"];
> EXTERNAL = 2 [(beam_urn) = "beam:env:external:v1"];
> }
> }
> // The payload of a Docker image
> message DockerPayload {
> string container_image = 1; // implicitly linux_amd64.
> }
> message ProcessPayload {
> string os = 1; // "linux", "darwin", ..
> string arch = 2; // "amd64", ..
> string command = 3; // process to execute
> map<string, string> env = 4; // environment variables
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
