[ https://issues.apache.org/jira/browse/BEAM-5036?focusedWorklogId=150609&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-150609 ]
ASF GitHub Bot logged work on BEAM-5036: ---------------------------------------- Author: ASF GitHub Bot Created on: 03/Oct/18 05:42 Start Date: 03/Oct/18 05:42 Worklog Time Spent: 10m Work Description: timrobertson100 commented on issue #6289: [BEAM-5036] Optimize the FileBasedSink WriteOperation.moveToOutput() URL: https://github.com/apache/beam/pull/6289#issuecomment-426518043 I have tested HDFS (the whole point of this PR) and the performance is listed above (100 minutes drops to 37 minutes for a basic rewrite of 1.5TB avro file on a 10 node cluster). GCS rename does a copy() and delete() internally, so should be the same runtime but I agree it should be confirmed as should local ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 150609) Time Spent: 8h 40m (was: 8.5h) > Optimize FileBasedSink's WriteOperation.moveToOutput() > ------------------------------------------------------ > > Key: BEAM-5036 > URL: https://issues.apache.org/jira/browse/BEAM-5036 > Project: Beam > Issue Type: Improvement > Components: io-java-files > Affects Versions: 2.5.0 > Reporter: Jozef Vilcek > Assignee: Tim Robertson > Priority: Major > Time Spent: 8h 40m > Remaining Estimate: 0h > > moveToOutput() methods in FileBasedSink.WriteOperation implements move by > copy+delete. It would be better to use a rename() which can be much more > effective for some filesystems. > Filesystem must support cross-directory rename. BEAM-4861 is related to this > for the case of HDFS filesystem. > Feature was discussed here: > http://mail-archives.apache.org/mod_mbox/beam-dev/201807.mbox/%3CCAF9t7_4Mp54pQ+vRrJrBh9Vx0=uaknupzd_qdh_qdm9vxll...@mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)