[
https://issues.apache.org/jira/browse/BEAM-5668?focusedWorklogId=151870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151870
]
ASF GitHub Bot logged work on BEAM-5668:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/18 21:07
Start Date: 05/Oct/18 21:07
Worklog Time Spent: 10m
Work Description: aaltay commented on a change in pull request #6588:
[BEAM-5668] Revert "[BEAM-5442] Pass unknown SDK pipeline options to Runner
(#6557)"
URL: https://github.com/apache/beam/pull/6588#discussion_r223139019
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -214,19 +213,7 @@ def get_all_options(self, drop_default=False):
subset[str(cls)] = cls
for cls in subset.values():
cls._add_argparse_args(parser) # pylint: disable=protected-access
- known_args, unknown_args = parser.parse_known_args(self._flags)
- # Parse args which are not known at this point but might be recognized
- # at a later point in time, i.e. by the actual Runner.
- if unknown_args and unknown_args[0] != '':
- logging.info("Parsing unknown args: %s", unknown_args)
- for arg in unknown_args:
- if arg.startswith('--'):
- parser.add_argument(arg.split('=', 1)[0], nargs='?')
Review comment:
I believe you need to change here to. Argparse accepts arguments without an
equals sign as well. For example `--myargname=myargvalue` would be equivalent
to `--myargname myargvalue`. In the latter case, the `split` will return the
whole thing.
cc: @mxm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 151870)
Time Spent: 1h 20m (was: 1h 10m)
> [beam_PostCommit_Python_Verify] [:pythonPostCommit] Many tests failing
> ----------------------------------------------------------------------
>
> Key: BEAM-5668
> URL: https://issues.apache.org/jira/browse/BEAM-5668
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Scott Wegner
> Assignee: Maximilian Michels
> Priority: Major
> Labels: currently-failing
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> _Use this form to file an issue for test failure:_
> * [Jenkins
> Job|https://builds.apache.org/job/beam_PostCommit_Python_Verify/6181/]
> * [Gradle Build
> Scan|https://scans.gradle.com/s/fcpta7s7wcsnm/console-log?task=:beam-sdks-python:postCommitITTests]
> * [Test source
> code|https://github.com/apache/beam/blob/4c693e7aa1ba71fa83370dd383f4bcebe4690b86/sdks/python/apache_beam/io/gcp/pubsub_integration_test.py#L171]
> * [Dataflow
> job|https://pantheon.corp.google.com/dataflow/jobsDetail/locations/us-central1/jobs/2018-10-05_07_00_20-5526009939236014896?project=apache-beam-testing]
> Initial investigation:
> Lots of different looking test failures from the Gradle build scan.
> ----
> _After you've filled out the above details, please [assign the issue to an
> individual|https://beam.apache.org/contribute/postcommits-guides/index.html#find_specialist].
> Assignee should [treat test failures as
> high-priority|https://beam.apache.org/contribute/postcommits-policies/#assigned-failing-test],
> helping to fix the issue or find a more appropriate owner. See [Apache Beam
> Post-Commit
> Policies|https://beam.apache.org/contribute/postcommits-policies]._
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
