[
https://issues.apache.org/jira/browse/BEAM-5442?focusedWorklogId=151964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151964
]
ASF GitHub Bot logged work on BEAM-5442:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/18 11:16
Start Date: 06/Oct/18 11:16
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #6589:
[BEAM-5442] Attempt to fix postcommit breakage.
URL: https://github.com/apache/beam/pull/6589#discussion_r223179379
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -220,12 +220,13 @@ def get_all_options(self, drop_default=False):
if unknown_args and unknown_args[0] != '':
logging.info("Parsing unknown args: %s", unknown_args)
for arg in unknown_args:
- if arg.startswith('--'):
+ # https://issues.apache.org/jira/browse/BEAM-5442
+ if arg.startswith('--') and not arg.startswith('--beam_plugins'):
Review comment:
Will do a follow-up because this just cures a symptom. We need an extra
check to avoid registering the same option twice.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 151964)
Time Spent: 6h 20m (was: 6h 10m)
> PortableRunner swallows custom options for Runner
> -------------------------------------------------
>
> Key: BEAM-5442
> URL: https://issues.apache.org/jira/browse/BEAM-5442
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, sdk-py-core
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Major
> Labels: portability, portability-flink
> Fix For: 2.8.0
>
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> The PortableRunner doesn't pass custom PipelineOptions to the executing
> Runner.
> Example: {{--parallelism=4}} won't be forwarded to the FlinkRunner.
> (The option is just removed during proto translation without any warning)
> We should allow some form of customization through the options, even for the
> PortableRunner.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
