[
https://issues.apache.org/jira/browse/BEAM-5315?focusedWorklogId=151969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-151969
]
ASF GitHub Bot logged work on BEAM-5315:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Oct/18 11:47
Start Date: 06/Oct/18 11:47
Worklog Time Spent: 10m
Work Description: splovyt commented on a change in pull request #6590:
[BEAM-5315] Partially port io
URL: https://github.com/apache/beam/pull/6590#discussion_r223180087
##########
File path: sdks/python/setup.py
##########
@@ -136,11 +136,17 @@ def get_version():
'pyhamcrest>=1.9,<2.0',
]
+GCP_REQUIREMENTS_PY2_ONLY = [
+ 'googledatastore==7.0.1'
+]
+
+GCP_REQUIREMENTS_PY3_ONLY = [
+]
+
GCP_REQUIREMENTS = [
# oauth2client >=4 only works with google-apitools>=0.5.18.
'google-apitools>=0.5.18,<=0.5.20',
'proto-google-cloud-datastore-v1>=0.90.0,<=0.90.4',
- 'googledatastore==7.0.1',
Review comment:
I have updated my setup.py to the latest version in the master for testing
purposes and have added a version qualifier instead. Thanks for the feedback.
PTAL at the next commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 151969)
Time Spent: 40m (was: 0.5h)
> Finish Python 3 porting for io module
> -------------------------------------
>
> Key: BEAM-5315
> URL: https://issues.apache.org/jira/browse/BEAM-5315
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Robbe
> Assignee: Simon
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
