[
https://issues.apache.org/jira/browse/BEAM-5621?focusedWorklogId=152333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-152333
]
ASF GitHub Bot logged work on BEAM-5621:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Oct/18 17:59
Start Date: 08/Oct/18 17:59
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #6602:
[BEAM-5621] Fix unorderable types in python 3
URL: https://github.com/apache/beam/pull/6602#discussion_r223450184
##########
File path: sdks/python/apache_beam/transforms/util.py
##########
@@ -223,7 +223,7 @@ def __init__(self,
if target_batch_duration_secs and target_batch_duration_secs <= 0:
raise ValueError("target_batch_duration_secs (%s) must be positive" % (
target_batch_duration_secs))
- if max(0, target_batch_overhead, target_batch_duration_secs) == 0:
+ if not (target_batch_overhead or target_batch_duration_secs):
Review comment:
Why did we need this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 152333)
Time Spent: 20m (was: 10m)
> Several tests fail on Python 3 with TypeError: unorderable types: str() <
> int()
> -------------------------------------------------------------------------------
>
> Key: BEAM-5621
> URL: https://issues.apache.org/jira/browse/BEAM-5621
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: Juta Staes
> Priority: Major
> Fix For: Not applicable
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> ======================================================================
> ERROR: test_remove_duplicates
> (apache_beam.transforms.ptransform_test.PTransformTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/common.py",
> line 677, in process
> self.do_fn_invoker.invoke_process(windowed_value)
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/runners/common.py",
> line 414, in invoke_process
> windowed_value, self.process_method(windowed_value.value))
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/transforms/core.py",
> line 1068, in <lambda>
> wrapper = lambda x: [fn(x)]
> File
> "/usr/local/google/home/valentyn/projects/beam/clean_head/beam/sdks/python/apache_beam/testing/util.py",
> line 115, in _equal
> sorted_expected = sorted(expected)
> TypeError: unorderable types: str() < int()
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
