[ https://issues.apache.org/jira/browse/BEAM-5036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16643903#comment-16643903 ]
Tim Robertson commented on BEAM-5036: ------------------------------------- {quote}Should this be marked as a blocker for 2.8.0 ? PR is still in review. {quote} I don't think this can block 2.8.0 for time constraints. The [PR (now closed)|https://github.com/apache/beam/pull/6289] caused a lot of discussion but was not suitable for merging. I suggest we modify {{HDFSFileSystem}} to always overwrite (i.e. move the necessary bits from the [existing PR|https://github.com/apache/beam/pull/6289] into the HDFS implementation only) and then the solution will be simpler and the change can be made to {{rename()}}. > Optimize FileBasedSink's WriteOperation.moveToOutput() > ------------------------------------------------------ > > Key: BEAM-5036 > URL: https://issues.apache.org/jira/browse/BEAM-5036 > Project: Beam > Issue Type: Improvement > Components: io-java-files > Affects Versions: 2.5.0 > Reporter: Jozef Vilcek > Assignee: Tim Robertson > Priority: Major > Time Spent: 11h > Remaining Estimate: 0h > > moveToOutput() methods in FileBasedSink.WriteOperation implements move by > copy+delete. It would be better to use a rename() which can be much more > effective for some filesystems. > Filesystem must support cross-directory rename. BEAM-4861 is related to this > for the case of HDFS filesystem. > Feature was discussed here: > http://mail-archives.apache.org/mod_mbox/beam-dev/201807.mbox/%3CCAF9t7_4Mp54pQ+vRrJrBh9Vx0=uaknupzd_qdh_qdm9vxll...@mail.gmail.com%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)